Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lightbox media viewer] Allow for isolated image view on mobile #6329

Closed
kirbyevans opened this issue Jun 9, 2021 · 4 comments
Closed

[Lightbox media viewer] Allow for isolated image view on mobile #6329

kirbyevans opened this issue Jun 9, 2021 · 4 comments
Labels
adopter: AEM used when component or pattern will be used by this adopter adopter support epic Feature request A new adopter requested feature icebox used for all issues in the Icebox pipeline. Stalebot ignores these issues when this label is added. priority: low

Comments

@kirbyevans
Copy link

The problem

We suspect that a user will need to view an image larger than how it is currently displayed within the lightbox media viewer on mobile (sm breakpoint).

The solution

We think by providing functionality to allow a user to isolate and zoom in on an image within the Lightbox media viewer that this new functionality could accomplish the user's desire to view an image larger.

Additional information

Design specs for the proposed solution can be found here:

PDF
Sketch file

Preview of specs for isolated image within the Lightbox media viewer
image
image

@shixiedesign
Copy link
Contributor

To be turned into Epic: design spec done. Need func spec, dev issue, QA issues. We need 1 website issue for all the lightbox changes coming from AEM (6328, 6329, 6314)

@ljcarot
Copy link
Member

ljcarot commented Jul 27, 2021

@shixiedesign Do you think we can get some testing of this feature request before building it out. I'm concerned that we are building a heavy duty lightbox viewer before MVP of the new product page has even launched. If I'm on mobile, I should be able to pinch the image on the page even if I can't pinch the image in the lightbox. It feels like an extreme edge case to build for so early in our creation of the pp in Carbon.

@shixiedesign
Copy link
Contributor

@ljcarot Yes I agree. I'm thinking we icebox this issue until the other 2 Lightbox enhancements are merged first? Meanwhile we can build out an inVision test to verify the UX.

@RobertaJHahn
Copy link

Icebox'd this epic and all linked issues based on comments above.

@RobertaJHahn RobertaJHahn added the icebox used for all issues in the Icebox pipeline. Stalebot ignores these issues when this label is added. label Jul 28, 2021
@kennylam kennylam closed this as completed Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adopter: AEM used when component or pattern will be used by this adopter adopter support epic Feature request A new adopter requested feature icebox used for all issues in the Icebox pipeline. Stalebot ignores these issues when this label is added. priority: low
Projects
None yet
Development

No branches or pull requests

9 participants