Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lightbox media viewer] React Wrapper: change the component to include a carousel #6375

Closed
10 tasks
RobertaJHahn opened this issue Jun 15, 2021 · 2 comments
Closed
10 tasks
Labels
dev Needs some dev work Feature request A new adopter requested feature inactive package: react Work necessary for the Carbon for IBM.com react components package priority: low

Comments

@RobertaJHahn
Copy link

RobertaJHahn commented Jun 15, 2021

User Story

As a [user role below]:
Carbon for ibm.com developer

I need to:
create/change the Lightbox media viewer

so that I can:
provide the ibm.com adopter developers components they can use to build ibm.com web pages

Additional information

Acceptance criteria

  • Built as a pure React component/variant
  • Include README for the react component and corresponding styles
  • Add any necessary stable selectors
  • Create codesandbox example under /packages/react/examples/codesandbox and include in README
  • Minimum 80% unit test coverage
  • Update the Carbon for ibm.com website component data file to be sure the web site Component Status and Storybook links are correct
  • Use the Visual QA checklist to verify design quality
  • DDS design consultant is included as a Reviewer in the Pull Request
  • Provide a direct link to the deploy preview for the designer in the Pull Request description
  • A comment is posted in the Prod QA issue, tagging Praveen when development is finished
@RobertaJHahn RobertaJHahn added dev Needs some dev work package: react Work necessary for the Carbon for IBM.com react components package priority: high labels Jun 15, 2021
@RobertaJHahn RobertaJHahn added Needs design approval PRs on feature requests and new components have to get design approval before merge. Feature request A new adopter requested feature priority: low and removed priority: high labels Jun 15, 2021
@RobertaJHahn RobertaJHahn self-assigned this Jul 6, 2021
@RobertaJHahn RobertaJHahn removed their assignment Jul 6, 2021
@shixiedesign shixiedesign removed Needs design approval PRs on feature requests and new components have to get design approval before merge. Needs func specs labels Jul 23, 2021
@RobertaJHahn RobertaJHahn changed the title [Lightbox media viewer] React: change the component to include a carousel [Lightbox media viewer] React Wrapper: change the component to include a carousel Jul 26, 2021
@jeffchew jeffchew added this to the Sprint 21-22 milestone Aug 24, 2021
@jeffchew jeffchew modified the milestones: Sprint 21-22, Sprint 21-23 Oct 18, 2021
@jeffchew jeffchew removed this from the Sprint 21-25 milestone Dec 2, 2021
@stale
Copy link

stale bot commented Apr 27, 2022

We've marked this issue as stale because there hasn't been any activity for 60 days. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the inactive label Apr 27, 2022
@stale
Copy link

stale bot commented May 28, 2023

As there's been no activity since this issue was marked as stale, we are auto-closing it.

@stale stale bot closed this as completed May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Needs some dev work Feature request A new adopter requested feature inactive package: react Work necessary for the Carbon for IBM.com react components package priority: low
Projects
None yet
Development

No branches or pull requests

3 participants