Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

fix(radio-button): apply disabled prop to input #703

Merged
merged 2 commits into from
Oct 4, 2021
Merged

fix(radio-button): apply disabled prop to input #703

merged 2 commits into from
Oct 4, 2021

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Sep 29, 2021

Related Ticket(s)

#695

Description

This PR passes the value of the disabled prop to the shadow DOM input and also prevents checked from being applied if the input is already disabled

Confirm that a disabled radio input can no longer be manipulated

@emyarod emyarod requested a review from a team as a code owner September 29, 2021 21:15
@emyarod emyarod requested review from BrunnoM7, annawen1 and skuruvil and removed request for a team September 29, 2021 21:15
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 29, 2021 •
edited
Loading

Deploy preview created for Carbon Web Components - Vue:
https://carbon-web-components-vue.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/703/index.html

Built with commit: bb9bdc08c0868b3a6a9711083d3de0373d842265

@emyarod emyarod force-pushed the 695-fix/radio-button-disabled-prop branch from 7ff13be to bb9bdc0 Compare September 29, 2021 21:55
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 29, 2021 •
edited
Loading

Deploy preview created for Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/703/index.html

Built with commit: bb9bdc08c0868b3a6a9711083d3de0373d842265

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for Carbon Web Components - React:
https://carbon-web-components-react.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/703/index.html

Built with commit: bb9bdc08c0868b3a6a9711083d3de0373d842265

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for Carbon Web Components - Angular:
https://carbon-web-components-angular.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/703/index.html

Built with commit: bb9bdc08c0868b3a6a9711083d3de0373d842265

jeffchew
jeffchew approved these changes Oct 1, 2021
View reviewed changes
Copy link
Member

@jeffchew jeffchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeffchew jeffchew added hacktoberfest-accepted Ready to merge Label for the pull requests that are ready to merge labels Oct 1, 2021
@kodiakhq kodiakhq bot merged commit c09b505 into carbon-design-system:master Oct 4, 2021
@emyarod emyarod deleted the 695-fix/radio-button-disabled-prop branch October 4, 2021 14:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeffchew jeffchew jeffchew approved these changes

@BrunnoM7 BrunnoM7 Awaiting requested review from BrunnoM7 BrunnoM7 was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@skuruvil skuruvil Awaiting requested review from skuruvil skuruvil was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
hacktoberfest-accepted Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emyarod @ibmdotcom-bot @jeffchew