Skip to content
This repository has been archived by the owner on Feb 5, 2024. It is now read-only.

[Pages] Guidelines: Typography #475

Closed
4 of 6 tasks
jeanservaas opened this issue Nov 27, 2018 · 13 comments
Closed
4 of 6 tasks

[Pages] Guidelines: Typography #475

jeanservaas opened this issue Nov 27, 2018 · 13 comments
Assignees

Comments

@jeanservaas
Copy link
Contributor

jeanservaas commented Nov 27, 2018

Elements-Typography
A user can discover the new DL Elements guidance for Typography as it relates to both Product and Editorial, surface the type sets and tokens and understand why / how to use them.

Design and Content

  • Overview Tab: redesign layout and create/update and usage guidance
    • Bring over universal guidance from DL Type Specs in UI page
    • Remove irrelevant or out of date guidance.
    • Add new guidance or expand on existing guidance
  • Productive Tab: redesign layout and create/update and usage guidance
    • Update all tokens
    • Create a new interaction to tab between Component and Layout tokens
    • Remove irrelevant or out of date guidance.
    • Add new guidance or expand on existing guidance
  • Expressive Tab: redesign layout and create/update and usage guidance
    • Update all tokens
    • Create a new interaction to tab between Component and Layout tokens
    • Bring over guidance content from Digital site
  • Images: update all exhibit images with new styles / create assets

Development

image

@jeanservaas
Copy link
Contributor Author

jeanservaas commented Nov 27, 2018

Type Elements v10

Sketch File
https://ibm.box.com/s/s4rbemheg3ing49khjeukcvxugbw4oet

@aagonzales @eraymond25 we now have an Epic for Elements so I'm moving this issue over.

Here's how I handled the new type pages for Carbon (the tokens are in there too). Structure should be similar to what Anna and I outlined last week:

  1. Unlike the digital site, we stayed away from the higher-level typographic guidance, pulling in only the UI type specs content from the DL site that applies to both Editorial and Product themes; (Biggest change: I moved "Fluid type" and "Line Length" into their respective sections so they can be with their type sets. There's no way the "Line Length" dropdown can accommodate all of the type tokens... so if we don't like this, we should think about simplifying this guidance like the digital site has done.)

  2. I pulled apart Product and Editorial themes into different tabs... I borrowed from both the opening content of Carbon and the opening content of the digital site for the intro copy... It needs some help, but it's a start.

  3. The type sets within both Product and Editorial have component tokens and layout tokens... so I modified the design to make more of a sub-tab module within the page. I tried some other designs / content switchers, but this one worked the best.

  4. You'll see that the Editorial page Layout tokens are the only ones that have the breakpoint slider.

type specs_overview
type specs_product_1
type specs_product_2
type specs_editorial_1
type specs_editorial_2

@jeanservaas
Copy link
Contributor Author

Copied feedback from @aagonzales

Feedback:

  • Other than refining some of the content I think it looks good!
  • Not sure you need the getting started section ... or at least not the Kit download. Seems redundant and the type stuff is scattered across the carbon and IDL files.
  • These last two examples are actually confusing, might help to put them in context. Otherwise they just looks like the bad examples a couple of rows up.

image

  • Under Production theme -- "v19a" is related to editorial/digital only. We'll need to work on that sentence some to get the correct context.
  • I think for editorial you might want to lead with Layout tokens instead of components, seems like those would be primarily used

@eraymond25
Copy link

Looking really good, a few things:

  1. Are we married to this style anchor link? I see it happening in the Design Language site and it looks a bit out of place and chunky to me. I get what they are doing, but maybe we could do it in a bit more graceful way.

screen shot 2018-11-27 at 2 05 08 pm

  1. The term editorial is used all over here and I've always found it confusing that we have Digital Design but it uses the Editorial typescale. Nowhere on this page says digital or ibm.com so I'm not immediately aware of what Editorial actually means. We have been talking about naming structures a lot lately since we're now using the IBM Design System as a code base... does Digital Design still make sense? Does editorial type make sense? Why are they not in coordination with each other?

  2. Why did we switch from heading to header? It doesn't feel right saying header

  3. The tokens may need to be class names for us @photodow can you weigh in on this? Are we able to use tokens or no?

This answer will mean we need to change the content under "IBM Editorial theme (look at content)"

  1. I think layout tokens tab should come first and component tokens should come second in both pages since thats mainly what people will be learning since the components are already made.

I also think in this tab we can be specific and say "Product layout tokens" and "Editorial layout tokens"to better exaggerate the fact that these are two different sets
screen shot 2018-11-27 at 2 11 59 pm

  1. These should both be sticky, the way you have it with the breakpoint tabs indented might look odd when it's sticky

screen shot 2018-11-27 at 2 15 43 pm

  1. Agreed with Anna, the Design kit tile should be actually just pointing to the design kit page rather than a download link. I also would take .sketch out because we're going to be adding other file types in there and actually currently have other file types in there today.

  2. You have the word Carbon under Typeface: IBM Plex :) need to take that out

@jeanservaas
Copy link
Contributor Author

Hi @eraymond25

Made the changes for 5 and 7 above. For issue 1, I'd like to table for now and just use the anchor link style IDL has for consistency sake... we can revisit later.

Issues 2, 3, 4, 8 relate to content so I don't want them to slow dev down on page creation... also anything relating to the token names decisions should also be captured here because we need to get them to @joshblack

Issue 6 about the tabs being sticky is a dev issue issue... that's what I was intending but we'll have to talk to @alisonjoseph about what's possible.

carbon-design-system/carbon-website#414

@shixiedesign shixiedesign changed the title Carbon X Release - Elements - Typography [Pages] Guidelines: Typography Nov 29, 2018
@joshblack
Copy link
Contributor

Just let me know what to update @jeanservaas! If you make an issue on carbon-elements and cc me I can get it added to our sprint 😄

@eraymond25
Copy link

@jeanservaas on your tabs for the type sets, I had initially thought the white background was selected (matching the system tags), but now that I saw the demo I think it's the dark one. This may be confusing and unexpected. Which one is unselected?

@jeanservaas
Copy link
Contributor Author

@eraymond25

Totally totally agree with the mixed signals from tab design above... here's an alternative, so we can be clear what tab we're on...

image

@aagonzales
Copy link
Member

aagonzales commented Dec 3, 2018

Sprint 25:

  • make updates to final markdown file
  • make sure final content is in v10 branch
  • alternate design for non-tab designs for mvp

@jeanservaas

@jeanservaas
Copy link
Contributor Author

jeanservaas commented Dec 4, 2018

Type Elements v10 REVISED

Sketch File
https://ibm.box.com/s/s4rbemheg3ing49khjeukcvxugbw4oet

  • We renamed / reorganized all type tokens so that they can live in the same repo (@joshblack)
  • Revised lead spaces to align with IDL and digital (removed large lead space in elements)
  • Eliminated nested tabbing component entirely
  • Changed names 'Product' and 'Editorial' to 'Productive' and 'Expressive' @eraymond25 (we may have to change it back to Product and editorial... waiting for wonil to weigh in

type specs_overview

type specs_productive

type specs_expressive

type page components

@shixiedesign
Copy link
Contributor

shixiedesign commented Dec 5, 2018

@jeanservaas
Copy link
Contributor Author

Quick design amendment on the Editorial page @alisonjoseph @claycrenshaw (this could potentially become a new issue or be changed in markdown with a pull request. I don't want to bog you down.

  • Mike wanted the fixed headings pulled out of the fluid category, he thought it was confusing; i agree

type specs_expressive

@claycrenshaw
Copy link
Contributor

Markdown has been updated to reflect new categorization.

@alisonjoseph
Copy link
Member

closing this issue, only thing left is breakpoint component and that is being tracked here. carbon-design-system/carbon-website#527

any content edits can just be added via PR to the website v10 branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants