Skip to content

Commit 0f1f287

Browse files
dakahntw15egan
authored andcommitted
fix(structured-list): fix DAP errors (#5066)
* fix(Dropdown): rely on list-box height closes #4916 * fix(structuredlist): remove role=presentation, remove htmlFor attribute Co-authored-by: TJ Egan <tw15egan@gmail.com>
1 parent b20b689 commit 0f1f287

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

packages/react/src/components/StructuredList/StructuredList-story.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ storiesOf('StructuredList', module)
7070
() => {
7171
const structuredListBodyRowGenerator = numRows => {
7272
return Array.apply(null, Array(numRows)).map((n, i) => (
73-
<StructuredListRow label key={`row-${i}`} htmlFor={`row-${i}`}>
73+
<StructuredListRow label key={`row-${i}`}>
7474
<StructuredListCell>Row {i}</StructuredListCell>
7575
<StructuredListCell>Row {i}</StructuredListCell>
7676
<StructuredListCell>

packages/react/src/components/StructuredList/StructuredList.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -222,9 +222,7 @@ export class StructuredListRow extends Component {
222222
{...other}
223223
tabIndex={tabIndex}
224224
className={classes}
225-
onKeyDown={onKeyDown}
226-
role="presentation" // eslint-disable-line jsx-a11y/no-interactive-element-to-noninteractive-role
227-
>
225+
onKeyDown={onKeyDown}>
228226
{children}
229227
</label>
230228
) : (

0 commit comments

Comments
 (0)