fix(button): remove margin added by safari (#5169)

tw15egan · web-flow · commit 2ce57b31b330 · 2020-01-29T09:55:59.000-08:00
* fix(button): remove margin added by safari

* fix(button): add button fix to reset file as well

* fix(button): make margin reset less browser specific
diff --git a/packages/components/src/components/button/_mixins.scss b/packages/components/src/components/button/_mixins.scss
@@ -29,6 +29,8 @@
   outline: none;
   position: relative;
   max-width: rem(320px);
+  // Fix to remove added margins on buttons in safari (see #5155)
+  margin: 0;
 
   &:disabled,
   &.#{$prefix}--btn--disabled {
diff --git a/packages/components/src/globals/scss/_css--reset.scss b/packages/components/src/globals/scss/_css--reset.scss
@@ -190,6 +190,11 @@
       box-sizing: border-box;
     }
 
+    // Fix to remove added margins on buttons in safari (see #5155)
+    button {
+      margin: 0;
+    }
+
     @include carbon--type-reset;
     @include carbon--icons;
   }

Original file line number	Diff line number	Diff line change
`@@ -190,6 +190,11 @@`
`190`	`190`	`box-sizing: border-box;`
`191`	`191`	`}`
`192`	`192`
	`193`	`+ // Fix to remove added margins on buttons in safari (see #5155)`
	`194`	`+ button {`
	`195`	`+ margin: 0;`
	`196`	`+ }`
	`197`	`+`
`193`	`198`	`@include carbon--type-reset;`
`194`	`199`	`@include carbon--icons;`
`195`	`200`	`}`