Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing Overflow menu with Esc key closes side nav #1398

Closed
carmacleod opened this issue Nov 6, 2018 · 2 comments
Closed

Closing Overflow menu with Esc key closes side nav #1398

carmacleod opened this issue Nov 6, 2018 · 2 comments
Assignees
@emyarod
Labels
severity: 3 https://ibm.biz/carbon-severity type: bug 🐛

Comments

@carmacleod
Copy link
Contributor

  1. Go to the Overflow Menu page
  2. Drop down an Overflow menu (using Space key or Enter key)
  3. Now type ESC to close the menu
  4. Notice that the Side Nav closes as well

The key handler for Esc needs to call event.stopPropagation();
and possibly also event.preventDefault();
@carmacleod
Copy link
Contributor Author

The Dropdown has the same problem. See point 2 of #1147.

@carmacleod carmacleod mentioned this issue Nov 14, 2018
Closed
@alisonjoseph alisonjoseph added severity: 3 https://ibm.biz/carbon-severity type: bug 🐛 labels Dec 7, 2018
@emyarod emyarod self-assigned this Dec 11, 2018
@carmacleod carmacleod mentioned this issue Jan 13, 2019
Closed
@emyarod
Copy link
Member

emyarod commented Feb 21, 2019

if I'm not mistaken this issue has been resolved by #1527

@emyarod emyarod closed this as completed Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emyarod emyarod

Labels
severity: 3 https://ibm.biz/carbon-severity type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alisonjoseph @carmacleod @emyarod