Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify danger is not a valid type of IconButton or <Button hasIconOnly/> #14300

Open
3 of 4 tasks
tay1orjones opened this issue Jul 25, 2023 · 1 comment
Open
3 of 4 tasks
Labels
planning: umbrella Umbrella issues, surfaced in Projects views role: design ✏️ type: docs 📖
Milestone

Comments

@tay1orjones
Copy link
Member

tay1orjones commented Jul 25, 2023

This has been a point of confusion for some time (#11484, #14295) and we have not clearly stated anywhere on the website or storybook (that I can find) that we do not support danger for the icon only button(s).

This includes both IconButton, and Button with hasIconOnly.

Pieces to fix

Preview Give feedback
  1. role: dev 🤖 status: ready to merge 🎉 type: docs 📖
    tay1orjones
  2. component: button package: @carbon/react role: dev 🤖
    ariellalgilmore
  3. component: button role: design ✏️ type: docs 📖
    alina-jacob
@tay1orjones tay1orjones moved this to ⏱ Backlog in Design System Jul 25, 2023
@sstrubberg sstrubberg added this to the 2023 Q3 milestone Aug 21, 2023
@tay1orjones tay1orjones modified the milestones: 2023 Q3, 2023 Q4 Oct 2, 2023
@sstrubberg sstrubberg modified the milestones: 2023 Q4, 2024 Q1 Jan 9, 2024
@tay1orjones tay1orjones moved this from ⏱ Backlog to 🪆 Needs Refined in Design System Mar 27, 2024
@tay1orjones tay1orjones removed this from the 2024 Q1 milestone Mar 27, 2024
@tay1orjones tay1orjones added this to the 2024 Q3 milestone Jul 19, 2024
@tay1orjones tay1orjones added the planning: umbrella Umbrella issues, surfaced in Projects views label Jul 24, 2024
@tay1orjones tay1orjones moved this from 🪆 Needs Refined to 🏗 In Progress in Design System Jul 24, 2024
@github-project-automation github-project-automation bot moved this to Triage in Roadmap Sep 16, 2024
@sstrubberg sstrubberg moved this from Triage to Now 💫 in Roadmap Sep 16, 2024
@sstrubberg sstrubberg modified the milestones: 2024 Q3, 2024 Q4 Sep 16, 2024
@albert-schilling
Copy link

I don't understand why Danger should not be allowed as a kind for the IconButton. We use it a lot in our app. For example for delete buttons or any kind of IconButton that does something destructive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
planning: umbrella Umbrella issues, surfaced in Projects views role: design ✏️ type: docs 📖
Projects
Status: 🏗 In Progress
Status: Now 💫
Development

No branches or pull requests

3 participants