Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio button selection not displayed in Windows high contrast mode #3184

Closed
JMGordon opened this issue Jun 26, 2019 · 11 comments
Closed

Radio button selection not displayed in Windows high contrast mode #3184

JMGordon opened this issue Jun 26, 2019 · 11 comments
Assignees
Labels
package: react carbon-components-react severity: 2 https://ibm.biz/carbon-severity type: a11y ♿

Comments

@JMGordon
Copy link
Contributor

JMGordon commented Jun 26, 2019

In the IBM Cloud portal the support case form is using the radio button component from carbon-components-react@6.115.3. In Windows high contrast mode radio button selection is not displayed, as can be seen in the below screen shot:
unified-support-windows-high-contrast

This issue also shows up in the carbon components react storybook:
radio-button-windows-high-contrast

@johnsteinbacher
Copy link

This issue is holding up the Console AVT exit. Because of that it is high priority for us.

@dakahn
Copy link
Contributor

dakahn commented Jun 26, 2019

Looking into why our radio button's aren't picking up the HCM styles in our reset. Thanks for reporting. 👍

@dakahn dakahn added priority: high severity: 1 https://ibm.biz/carbon-severity labels Jun 26, 2019
@dakahn dakahn self-assigned this Jun 26, 2019
@dakahn
Copy link
Contributor

dakahn commented Jul 2, 2019

@dakahn
Copy link
Contributor

dakahn commented Jul 2, 2019

related #1600

@abbeyhrt abbeyhrt added the package: react carbon-components-react label Jul 16, 2019
@dakahn
Copy link
Contributor

dakahn commented Jul 17, 2019

Working on this currently. Watch this space for a PR, folks.

@dakahn
Copy link
Contributor

dakahn commented Jul 17, 2019

Have a fix up for Edge/IE. Firefox is tough though -- the -ms-high-contrast: active selector isn't compatible there and supporting HCM formally might involve a larger refactor re-examining creating the active state fill in effect with CSS only.

@dakahn dakahn added severity: 2 https://ibm.biz/carbon-severity and removed severity: 1 https://ibm.biz/carbon-severity labels Jul 17, 2019
@dakahn
Copy link
Contributor

dakahn commented Jul 17, 2019

I'm lowering the severity since we have a workaround with Edge and Chrome 👍

@dakahn
Copy link
Contributor

dakahn commented Jul 18, 2019

With the aforementioned PR #3442 we should have HCM support for MS browsers as well as Chrome (via their high-contrast extension). We do not support High Contrast Mode on Windows for Firefox due to that browsers lack of support for the necessary Microsoft CSS extension used to detect HCM. Though there are Bugzilla proposals for a prefers-contrast media query seen here. We will watch that issue and update accordingly 👍🏽

@elizabethsjudd
Copy link
Contributor

elizabethsjudd commented Jul 18, 2019

@dakahn has this ☝️ been okay'd by the IBMa team (to post-pone support for Firefox)? Is it possible to get that documented somewhere so our offerings are aware?

@dakahn
Copy link
Contributor

dakahn commented Jul 18, 2019

@elizabethsjudd writing up something official we can point to as we speak 👍.

It was a topic during the IBMa morning standup today and they reached consensus that Windows HCM support on Edge, IE, and Chrome was enough.

@dakahn
Copy link
Contributor

dakahn commented Jul 19, 2019

wrote up some background at #3478

@dakahn dakahn closed this as completed Jul 22, 2019
@dakahn dakahn added this to the IBMa Carbon Copy milestone Jul 22, 2019
@dakahn dakahn modified the milestones: IBMa Carbon Copy, ♿Carbon WCAG Compliance♿ Nov 21, 2019
@mattrosno mattrosno removed this from the ♿Carbon WCAG Compliance♿ milestone Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: react carbon-components-react severity: 2 https://ibm.biz/carbon-severity type: a11y ♿
Projects
None yet
Development

No branches or pull requests

6 participants