Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SkipToContent]: no documentation, fails DAP contrast, unnecessary required prop #4802

Closed
vpicone opened this issue Dec 2, 2019 · 0 comments · Fixed by #4875
Closed

[SkipToContent]: no documentation, fails DAP contrast, unnecessary required prop #4802

vpicone opened this issue Dec 2, 2019 · 0 comments · Fixed by #4875
Assignees

Comments

@vpicone
Copy link
Contributor

vpicone commented Dec 2, 2019

The SkipToContent component and it's functionality are critical to accessible apps, we should definitely be polishing this.

Issues with the SkipToContent component:

  • this component's existance/props are effectively undocumented (even in stories where it is used) storybook isn't picking up many of individual the shell components
  • the component fails DAP contrast static analysis. DAP is comparing the default link color to the shell background. This could be fixed by making the link white at all times, not just during focus.
  • The component requires an href but provides one as a default. Even in our stories, we don't provide one. Allowing use of default is fine, we shouldn't throw prop-type warnings when folks do so.
  1. Navigate to a story using SkipToContent
  2. Click show info. Notice no prop table or story source
  3. Run DAP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants