Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm script names don't match the npm scripts guide #9

Open
grahamharper opened this issue Jun 15, 2020 · 2 comments · May be fixed by #10
Open

npm script names don't match the npm scripts guide #9

grahamharper opened this issue Jun 15, 2020 · 2 comments · May be fixed by #10

Comments

@grahamharper
Copy link

The npm scripts guide says

develop - this is your primary for starting up your gatsby site for development
develop:clean - this is provided as a convenience; it first runs clean then develop

https://github.com/carbon-design-system/gatsby-starter-carbon-theme/blob/master/src/pages/guides/npm-scripts.mdx#develop

But the actual scripts in this starter are dev and dev:clean

https://github.com/carbon-design-system/gatsby-starter-carbon-theme/blob/master/package.json
@vpicone
Copy link
Contributor

vpicone commented Jun 15, 2020

Yikes, that's annoying. Do you mind opening a PR for that to the starter?

@grahamharper
Copy link
Author

Which should it be, dev or develop?

@grahamharper grahamharper linked a pull request Sep 1, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix npm script names grahamharper/gatsby-starter-carbon-theme
2 participants
@grahamharper @vpicone