Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove extra spacing in aside component #325

Merged
merged 3 commits into from
Aug 13, 2019
Merged

fix: remove extra spacing in aside component #325

merged 3 commits into from
Aug 13, 2019

Conversation

alisonjoseph
Copy link
Member

@alisonjoseph alisonjoseph commented Aug 8, 2019 •
edited
Loading

ref carbon-design-system/design-language-website#139

matches aside spacing to live IDL site. Updates example column width to match IDL also.

@vercel
Copy link

vercel bot commented Aug 8, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://gatsby-theme-carbon-git-fork-alisonjoseph-aside-fix.carbon-design-system.now.sh

@vercel vercel bot temporarily deployed to staging August 8, 2019 20:03 Inactive
@vercel vercel bot temporarily deployed to staging August 8, 2019 20:05 Inactive
abbeyhrt
abbeyhrt approved these changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@abbeyhrt abbeyhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🎉

@alisonjoseph alisonjoseph merged commit 9841346 into carbon-design-system:master Aug 13, 2019
@alisonjoseph alisonjoseph deleted the aside-fix branch August 13, 2019 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpicone vpicone vpicone approved these changes

@abbeyhrt abbeyhrt abbeyhrt approved these changes

@emyarod emyarod Awaiting requested review from emyarod

Assignees
No one assigned
Labels
status: ready for review 👀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alisonjoseph @vpicone @abbeyhrt