Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for choosing line break position in page-title #409

Closed
SilverFox70 opened this issue Sep 10, 2019 · 1 comment · Fixed by #420
Closed

Support for choosing line break position in page-title #409

SilverFox70 opened this issue Sep 10, 2019 · 1 comment · Fixed by #420

Comments

@SilverFox70
Copy link
Contributor

SilverFox70 commented Sep 10, 2019

Aesthetically this has some intersection with #308 and also relates to Brand Center #443. The desire is to be able to finesse where a line break occurs in the page-title as it appears in the PageHeader. We did a brief exploration of achieving this:

<h1 id="page-title" className={text}>
  <div dangerouslySetInnerHTML={{ __html: frontmatter.title || null }}/>
</h1>
@vpicone
Copy link
Collaborator

vpicone commented Sep 12, 2019

@SilverFox70 This approach wouldn't work for any other places in the site that use title: search, custom navigation components, the HTML title header. I have an alternative approach that I'm pushing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants