fix[spacing]: paragraphs following h4s need 0 margin top

[jeanservaas]

fix[spacing]: paragraphs following h4s need 0 margin top

After pushing the new spacing fix, we have to tweak the H4s in the theme:

• all paragraphs following h4s should have 0 margin top
• create a FigureTitle component so folks don’t have to hijack h4's to get a figure title (leaving images, figures, videos etc. to still get the sapce)

This is what's happening right now... creating super confusing hierarchies across the Carbon site:

[jnm2377]

Looks like the spacing in the paragraph is actually coming from the row. Row's are now receiving a margin-top: 1.5rem coming from these styles: https://github.com/vpicone/gatsby-theme-carbon/blob/d9e6fdc0d80228b6c1326968cba2f0663772d7a6/packages/gatsby-theme-carbon/src/components/Main/Main.module.scss#L11-L18

[rcwakelin]

PR request to come soon.

[mjabbink]

See second bullet above. This seems to have been missed.

references:

—

—

[vpicone]

@mjabbink opened #591 to track this. Is there something visually wrong with those figure titles or are you just saying they shouldn't be h4s?

[mjabbink]

the spacing under the header is too tight. Not sure what the exact spec is but by best guess is 16 or 24px. @jeanservaas can provide exact pixels.

[mjabbink]

also effects here with this header size too. Needs more space under neath above text and image in this case https://www.ibm.com/brand/advertising

[jeanservaas]

the space after the figure title should be 24px -- or rather, allow the image to have the 24px margin top in this scenario.

[mjabbink]

What about the larger header in above sample?