Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(skip-to-content): make link text white to meet AA contrast #571

Merged
merged 2 commits into from
Dec 2, 2019
Merged

fix(skip-to-content): make link text white to meet AA contrast #571

merged 2 commits into from
Dec 2, 2019

Conversation

jendowns
Copy link
Contributor

Closes #570

Changelog

Changed

  • make the SkipToContent link text white so that it makes AA minimum contrast requirements

@vercel
Copy link

vercel bot commented Nov 26, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/carbon-design-system/gatsby-theme-carbon/86p0dgkv3
🌍 Preview: https://gatsby-theme-carbon-git-fork-jendowns-570skip-to-content.carbon-design-system.now.sh

(da029af, update in progress)

Copy link
Collaborator

@vpicone vpicone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that's annoying, it's comparing using the link blue rather than the white it uses when it's actually rendered. So I don't think it's an actual violation, but good to get clear out the DAP error either way.

@vpicone vpicone merged commit f8881ed into carbon-design-system:master Dec 2, 2019
@vercel vercel bot requested a deployment to staging December 2, 2019 14:28 Abandoned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SkipToContent]: does not meet WCAG AA foreground/background contrast minimum
2 participants