feat: add title component #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/carbon-design-system/gatsby-theme-carbon/3ymlppy5p |
|
@jeanservaas Last bit needed is guidance on when someone would use this vs. a |
vpicone
requested review from
a team,
sstrubberg and
jnm2377
and removed request for
a team
jnm2377
approved these changes
Jan 16, 2020
|
After talking with @jeanservaas and @mjabbink I'm not so concerned about folks misconstruing Title and Caption. We can add additional guidance if that becomes a problem we actually see in the wild. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #625
demo: https://gatsby-theme-carbon-git-fork-vpicone-title-component.carbon-design-system.now.sh/components/Title