-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(GifPlayer): adds component to pause and play gifs for a11y #676
feat(GifPlayer): adds component to pause and play gifs for a11y #676
Conversation
…carbon into fix-global-spacing
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/carbon-design-system/gatsby-theme-carbon/7j8tv9ipg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/gatsby-theme-carbon/src/components/GifPlayer/GifPlayer.js
Outdated
Show resolved
Hide resolved
…r.js Co-Authored-By: DAK <40970507+dakahn@users.noreply.github.com>
…r.js Co-Authored-By: DAK <40970507+dakahn@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked the focus on FF Windows 10 and it looks great!
Rel carbon-design-system/design-language-website#411
This component adds pause and play functionality for gifs by replacing the gif with a static image (much like the way
ArtDirection
uses different images).It made the most sense to add this component to Gatsby since we use gif's in our Carbon site and IDL site.
New
GifPlayer
Changed
ImageGallery
functionality to work withGifPlayer
Review
GifPlayer
page in the left nav to see a working exampleImageGallery
pagearia-hidden="true/false"
bc even though the styles usedisplay:none
to toggle between the gif/static image, I still see the hidden images in the DOM). cc: @dakahn