Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is required setting of RowCount expected behavior? #10

Open
buckleyGI opened this issue Sep 16, 2016 · 4 comments
Open

Is required setting of RowCount expected behavior? #10

buckleyGI opened this issue Sep 16, 2016 · 4 comments

Comments

@buckleyGI
Copy link

Hi,

I'm starting to appreciate this component more and more as it just works out of the box.

Lets say I have 10 controls and have set columncount to 2.

It seems that I have to set rowcount as well but I was expecting the autogrid to derive it herslef.

Now I have to set it to 5 or to a big number like 1000 which also seems to work

Can RowCount not be derived for a reason? If it can be I'll contribute but wanted to check expected behavior and limitations first.

Kr, Tom

@carbonrobot
Copy link
Owner

Currently it does require both rowcount and columncount. It would be easy to default that to 1 for both if not specified. It would not be a breaking change.

I can push an update soon for this.

@buckleyGI
Copy link
Author

Hi Carbonrobot. I'm not sure we are talking about the same change.

If there are 10 controls in the autogrid and columncount is 2 I think I don't have to specify the rowcount.
The control can do the calculation and set rowcount to 5.
This allows the user to add controls and not (forget) to adjust the rowcount.

Hope I make sense now :)

@carbonrobot
Copy link
Owner

Ah I see. Thanks for clarifying that, will look into this.

@EdvardasDlugauskas
Copy link

I would really like to see this implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants