Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIP-0030: API methods for Governance E.g. Checking DRep delegation. #923

Closed
bakon11 opened this issue Oct 8, 2024 · 6 comments
Closed
Labels
Category: Wallets Proposals belonging to the 'Wallets' category.

Comments

@bakon11
Copy link

bakon11 commented Oct 8, 2024

With the ERA of on chain governance(CIP-1694) upon us. Many wallets are implementing governance tools For creating/delegating to dreps and casting votes.

Are there any plans on implementing API calls to check if connected wallet is associated/delegated to a DReps?

@bakon11 bakon11 changed the title CIP-0030 - API methods for Governance E.g. Checking DRep delegation. CIP-0030: API methods for Governance E.g. Checking DRep delegation. Oct 8, 2024
@rphair rphair added the Category: Wallets Proposals belonging to the 'Wallets' category. label Oct 9, 2024
@rphair
Copy link
Collaborator

rphair commented Oct 9, 2024

cc @Ryun1 - I was also wondering if such methods will fit into CIP-0030 as opposed to one or two of the wallet APIs that might supersede it (e.g. the candidate CIP-0090 or future alternative referred to here: #462 (comment))

@Ryun1
Copy link
Collaborator

Ryun1 commented Oct 9, 2024

Hey @bakon11

Are there any plans on implementing API calls to check if connected wallet is associated/delegated to a DReps?

Good question, in short probably not (feel free to propose a CIP30 extension to add this)

Having wallets serve governance data was something I avoided intentionally did not do for the CIP-30 governance extension (CIP-95).
I did this because I wanted to seek maximum adoption for CIP95/governance for wallets, so I moved the burden of indexing governance data from wallets to dApps

In general I tend to feel that the DApp specific logic (be it governance in this case) should place the indexing burden upon the DApp, rather than the wallet.

@bakon11
Copy link
Author

bakon11 commented Oct 9, 2024

@Ryun1

Agreed, I was more specifically speaking just about maybe being able to pull the DRep info, since most wallets already support dRep creation and delegation options anyways. and everything else exactly should be handled by the dApp,

@bakon11
Copy link
Author

bakon11 commented Oct 9, 2024

ahhh ok just looked through CIP-0095 makes sense now.

@rphair
Copy link
Collaborator

rphair commented Nov 4, 2024

@bakon11 does your last comment suggest that this issue can be closed? (cc @Ryun1)

@bakon11
Copy link
Author

bakon11 commented Nov 4, 2024

Yes, thank you.

@rphair rphair closed this as completed Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Wallets Proposals belonging to the 'Wallets' category.
Projects
None yet
Development

No branches or pull requests

3 participants