Rename delisted_pools table to pool_delistment.

In response to review feedback:

#2277 (comment)

Author: jonathanknowles

lib/core/src/Cardano/Pool/DB/Sqlite.hs

@@ -492,10 +492,10 @@ newDBLayer trace fp timeInterpreter = do
             -- TODO: remove dangling metadata no longer attached to a pool
 
         delistPools =
-            insertMany_ . fmap DelistedPool
+            insertMany_ . fmap PoolDelistment
 
         readDelistedPools =
-            fmap (delistedPoolPoolId . entityVal) <$> selectList [] []
+            fmap (delistedPoolId . entityVal) <$> selectList [] []
 
         removePools = mapM_ $ \pool -> do
             liftIO $ traceWith trace $ MsgRemovingPool pool
@@ -504,7 +504,7 @@ newDBLayer trace fp timeInterpreter = do
             deleteWhere [ PoolRegistrationPoolId ==. pool ]
             deleteWhere [ PoolRetirementPoolId ==. pool ]
             deleteWhere [ StakeDistributionPoolId ==. pool ]
-            deleteWhere [ DelistedPoolPoolId ==. pool ]
+            deleteWhere [ DelistedPoolId ==. pool ]
 
         removeRetiredPools epoch =
             bracketTracer traceOuter action
@@ -570,7 +570,7 @@ newDBLayer trace fp timeInterpreter = do
             deleteWhere ([] :: [Filter PoolOwner])
             deleteWhere ([] :: [Filter PoolRegistration])
             deleteWhere ([] :: [Filter PoolRetirement])
-            deleteWhere ([] :: [Filter DelistedPool])
+            deleteWhere ([] :: [Filter PoolDelistment])
             deleteWhere ([] :: [Filter StakeDistribution])
             deleteWhere ([] :: [Filter PoolMetadata])
             deleteWhere ([] :: [Filter PoolMetadataFetchAttempts])

lib/core/src/Cardano/Pool/DB/Sqlite/TH.hs

@@ -124,9 +124,9 @@ PoolRegistration sql=pool_registration
     Primary poolRegistrationPoolId poolRegistrationSlot poolRegistrationSlotInternalIndex
     deriving Show Generic
 
-DelistedPool sql=delisted_pool
-    delistedPoolPoolId                W.PoolId                      sql=pool_id
-    Primary delistedPoolPoolId
+PoolDelistment sql=pool_delistment
+    delistedPoolId                W.PoolId                      sql=pool_id
+    Primary delistedPoolId
     deriving Show Generic
 
 -- Mapping of retirement certificates to pools