fix: rollback issue fix after event window commitment finishes. #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiwinnetou
force-pushed
the
rollback-fix
branch
from
44d9465 to
37a6f0f
Compare
|
Actually I have an idea how to fix it better, commitment will still run if there is at least one vote_merkle_proof with invalidated status. That's it, it will fix it but on top we will stop rollback handling as currently in the code when commitment window finished. |
matiwinnetou
force-pushed
the
rollback-fix
branch
2 times, most recently
from
7dcd933 to
48220fe
Compare
matiwinnetou
force-pushed
the
rollback-fix
branch
from
48220fe to
e5ae458
Compare
matiwinnetou
force-pushed
the
rollback-fix
branch
from
f4e1427 to
401b0e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.