Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIP assets: images missing if in folder itself or for CPSs #1210

Closed
rphair opened this issue Feb 10, 2024 · 2 comments
Closed

CIP assets: images missing if in folder itself or for CPSs #1210

rphair opened this issue Feb 10, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@rphair
Copy link
Collaborator

rphair commented Feb 10, 2024

The current title states my best guess at the reason for the reason staging currently does not build: due to the recent merge of CPS-0010 (cardano-foundation/CIPs#619) and judging by the CIP build script output because of the image pathnames in that GitHub source (https://github.com/cardano-foundation/CIPs/blob/master/CPS-0010/README.md):

Error: Image docs/governance/cardano-problem-statements/no-data-wallet.drawio.png used in docs/governance/cardano-problem-statements/CPS-0010.md not found.
    at async Promise.all (index 0)
[ERROR] Client bundle compiled with errors therefore further build is impossible.

The CPS-0010 source uses the same relative-pathname syntax as successfully used for the images in CIP-0050... so my guess (not looking at the scripts yet; needed to prioritise reporting this problem while still on a bad Internet connection) is that either:

  • the prepended /images folder for CIP-0050 allows the script to recognise that there are assets to collect... but doesn't work for images in the CIP folder itself; or:
  • whatever rule is used to collect those images is only being run for CIP- documents but not for CPS- documents.

This is a hasty report, with some guesswork, since I'm still travelling almost daily & just wanted to blow the whistle on this, since it's affecting the CI build checking for all PRs open on the Dev Portal. cc @katomm @fill-the-fill @Ryun1

@rphair rphair added the bug Something isn't working label Feb 10, 2024
@fill-the-fill fill-the-fill self-assigned this Feb 12, 2024
@fill-the-fill
Copy link
Collaborator

Sorry, didn't see this before, I will take it on me

@rphair
Copy link
Collaborator Author

rphair commented Feb 13, 2024

Fixed by #1211. ☺️

@rphair rphair closed this as completed Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants