Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use text envelopes for hydra keys #530

Closed
4 tasks
Tracked by #518
ch1bo opened this issue Oct 4, 2022 · 0 comments · Fixed by #537
Closed
4 tasks
Tracked by #518

Use text envelopes for hydra keys #530

ch1bo opened this issue Oct 4, 2022 · 0 comments · Fixed by #537
Assignees
@v0d1ch
Labels
task Subtask of a bigger feature.

Comments

@ch1bo
Copy link
Member

ch1bo commented Oct 4, 2022 •
edited
Loading

Why

To make them easy to distinguish from any random bytes.

What

Analagous to cardano keys, the hydra keys can use text envelopes to make them easier to handle. We can leverage the cardano-api utilities for that, now that we have #398.

How

  • Use the cardano-api Text envelopes.
  • Update changelog (this is a breaking change).
  • Make sure all test/bench usage sites are good.
  • Update all our deployments using the new key format.
@ch1bo ch1bo mentioned this issue Oct 4, 2022
Closed
12 tasks
@ch1bo ch1bo changed the title Use text envelopes like cardano keys to make it easy to distinguish from any random bytes Use text envelopes like cardano keys Oct 4, 2022
@v0d1ch v0d1ch self-assigned this Oct 4, 2022
@pgrange pgrange changed the title Use text envelopes like cardano keys Use text envelopes for hydra keys Oct 4, 2022
@ch1bo ch1bo added the task Subtask of a bigger feature. label Oct 4, 2022
@v0d1ch v0d1ch mentioned this issue Oct 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@v0d1ch v0d1ch

Labels
task Subtask of a bigger feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

530 use text envelopes for hydra keys v0d1ch/hydra-poc
2 participants
@v0d1ch @ch1bo