Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid checking out worktree for --git #1208

Closed
NobodyXu opened this issue Jul 17, 2023 · 1 comment
Closed

Avoid checking out worktree for --git #1208

NobodyXu opened this issue Jul 17, 2023 · 1 comment

Comments

@NobodyXu
Copy link
Member

  • Support symlink handling in git::Repository::get_head_commit_entry_data_by_path
  • Support listing dir and checking whether a path is a dir in git::Repository
  • Use git::Repository::shallow_clone_bare in resolve.rs#L374 and modify load_manifest_from_workspace to support use git::Repository instead of worktree.
@NobodyXu NobodyXu changed the title More git::Repository feature Avoid checking out worktree for --git Jul 17, 2023
@NobodyXu NobodyXu mentioned this issue Jul 17, 2023
2 tasks
@NobodyXu
Copy link
Member Author

Hmmm it seems like that if we use shallow_clone_bare when dealiing when user provided --git, then we won't be able to handle submodule...

And load_manifest_from_workspace would have to be way more complicated with a trait for virtual filesystem.

Given that it is unlikely for any repository to be as large as crates.io-registry, I think it's better left as-is.

@NobodyXu NobodyXu closed this as not planned Won't fix, can't repro, duplicate, stale Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant