Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-binstall 0.13.2 failed to install cargo-watch #416

Closed
taiki-e opened this issue Sep 24, 2022 · 7 comments · Fixed by #418
Closed

cargo-binstall 0.13.2 failed to install cargo-watch #416

taiki-e opened this issue Sep 24, 2022 · 7 comments · Fixed by #418
Assignees
Labels
Blocked: upstream Fix or feature is needed to be implemented upstream (in a dependency) Report: bug Something isn't working

Comments

@taiki-e
Copy link

taiki-e commented Sep 24, 2022

cargo-binstall 0.13.2 failed to install cargo-watch with the following error:

05:14:15 [INFO] Resolving package: 'cargo-watch'
05:14:16 [INFO] The package will be downloaded from github.com
05:14:16 [INFO] This will install the following binaries:
05:14:16 [INFO]   - cargo-watch (cargo-watch -> /home/runner/.cargo/bin/cargo-watch-v8.1.2)
05:14:16 [INFO]   - cargo-watch (cargo-watch -> /home/runner/.cargo/bin/cargo-watch-v8.1.2)
05:14:16 [INFO] And create (or update) the following symlinks:
05:14:16 [INFO]   - cargo-watch (/home/runner/.cargo/bin/cargo-watch -> cargo-watch-v8.1.2)
05:14:16 [INFO]   - cargo-watch (/home/runner/.cargo/bin/cargo-watch -> cargo-watch-v8.1.2)
05:14:16 [INFO] Installing binaries...
Error: 05:14:16 [ERROR] Fatal error:
binstall::binfile

  × bin file /home/runner/.cargo/bin/cargo-binstallDqdKr7/bin-cargo-watch-
  │ x86_64-unknown-linux-gnu-GhCrateMeta/cargo-watch-v8.1.2-x86_64-unknown-
  │ linux-gnu/cargo-watch not found

full logs:
cargo-binstall 0.13.1 (passed): https://github.com/taiki-e/install-action/actions/runs/3117118429/jobs/5055540606
cargo-binstall 0.13.2 (failed): https://github.com/taiki-e/install-action/actions/runs/3117122909/jobs/5055549681

This was originally found in taiki-e/install-action#21, but I can confirm that this problem occurs locally as well.

@NobodyXu
Copy link
Member

Let me perform a bisect to see which commit caused this issue.

@NobodyXu
Copy link
Member

As expected, this bug is caused by #413 .

@NobodyXu
Copy link
Member

I think this bug might be related to https://gitlab.com/crates.rs/cargo_toml/-/merge_requests/15

@NobodyXu
Copy link
Member

The problem seems to be that cargo-binstall thinks there is two cargo-watch...

@NobodyXu NobodyXu added Report: bug Something isn't working Blocked: upstream Fix or feature is needed to be implemented upstream (in a dependency) labels Sep 24, 2022
@NobodyXu
Copy link
Member

I've updated PR https://gitlab.com/crates.rs/cargo_toml/-/merge_requests/15 and it should fixed this issue.
Would also add some test cases.

@NobodyXu
Copy link
Member

NobodyXu commented Sep 24, 2022

cargo-binstall v0.13.2 and binstalk v0.2.0 is now yanked.

@NobodyXu
Copy link
Member

@taiki-e cargo-binstall v0.13.3 has released, which fixed this issue.
We have re-added cargo-watch to our CI to ensure no regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked: upstream Fix or feature is needed to be implemented upstream (in a dependency) Report: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants