Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When ring@0.16.21 releases: upgrade and stop using patched ring 0.16 for windows ARM release builds #665

Closed
passcod opened this issue Jan 8, 2023 · 9 comments · Fixed by #1869
Closed

When ring@0.16.21 releases: upgrade and stop using patched ring 0.16 for windows ARM release builds #665

passcod opened this issue Jan 8, 2023 · 9 comments · Fixed by #1869
Labels
Blocked: upstream Fix or feature is needed to be implemented upstream (in a dependency)

Comments

@passcod
Copy link
Member

passcod commented Jan 8, 2023

See:

We currently use a patched ring 0.16 for release builds on Windows ARM. It seems the underlying issue will be resolved with ring 0.17, so we should stop doing that then.
@passcod passcod added the Blocked: upstream Fix or feature is needed to be implemented upstream (in a dependency) label Jan 8, 2023
@NobodyXu
Copy link
Member

NobodyXu commented Jan 9, 2023

ring is planning on a 0.16.21 release which will also fix the build for aarch64-pc-windows-msvc
briansmith/ring#1551

@passcod passcod changed the title When ring@0.17 releases: upgrade and stop using patched ring 0.16 for windows ARM release builds When ring@0.16.21 releases: upgrade and stop using patched ring 0.16 for windows ARM release builds Jan 12, 2023
@passcod
Copy link
Member Author

passcod commented Jun 24, 2023

I think we did this already?

@NobodyXu
Copy link
Member

I think we did this already?

We are still using v0.16.20

cargo-binstall/Cargo.lock

Line 2812 in ca00cba

[[package]]

@NobodyXu
Copy link
Member

I think the upstream hasn't released v0.16.21

@passcod
Copy link
Member Author

passcod commented Jun 24, 2023

ugh ffs

@sigoden
Copy link

sigoden commented Oct 26, 2023 •
edited
Loading

With ring v0.17.5 and rustls v0.21.8 released, it's time to move on.

@NobodyXu
Copy link
Member

There will be an automatic dependencies upgrade today, if that removes the old ring then I will open a PR to remove the patch and possibly cut a new patch release.

@NobodyXu
Copy link
Member

NobodyXu commented Oct 27, 2023 •
edited
Loading

#1474 bumps the dep, but it turns out that hickory-dns still uses ring v0.16, so have to wait for them to bump their ring again

@NobodyXu NobodyXu mentioned this issue Aug 10, 2024
Merged
@NobodyXu
Copy link
Member

Fixed in #1869

@NobodyXu NobodyXu linked a pull request Aug 10, 2024 that will close this issue
dep: Bump hickory-resolver to 0.25.0-alpha.2 #1869
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Blocked: upstream Fix or feature is needed to be implemented upstream (in a dependency)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dep: Bump hickory-resolver to 0.25.0-alpha.2 cargo-bins/cargo-binstall
3 participants
@passcod @sigoden @NobodyXu