Bloody hell, I think I finally got outdated to show the correctly out…

…dated gems. fixes #1174
rubygems · May 17, 2011 · 7cf8aea · 7cf8aea
1 parent 2be6859
commit 7cf8aea
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 7 deletions.
diff --git a/lib/bundler/cli.rb b/lib/bundler/cli.rb
@@ -300,13 +300,24 @@ def outdated(*gems)
       end
 
       options["local"] ? definition.resolve_with_cache! : definition.resolve_remotely!
-
+
+      Bundler.ui.info "Outdated gems included in the bundle:"
       definition.specs.each do |s|
-        cs = current_specs.find{|spec| spec.name == s.name }
-        if cs.version != s.version || cs.git_version != s.git_version
-          Bundler.ui.info "  * #{s.name} (#{s.version}#{s.git_version} > #{cs.version}#{cs.git_version}) "
+        next if !gems.empty? && !gems.include?(s.name)
+
+        s.source.fetch(s) if s.source.respond_to?(:fetch)
+
+        if s.git_version
+          cs = current_specs.find {|spec| spec.name == s.name }
+        else
+          cs = s
+          s = definition.index[cs.name].sort_by { |b| b.version }.last
+        end
+
+        if Gem::Version.new(s.version) > Gem::Version.new(cs.version) || cs.git_version != s.git_version
+          Bundler.ui.info "  * #{s.name} (#{s.version}#{s.git_version} > #{cs.version}#{cs.git_version})"
         end
-        Bundler.ui.debug "from #{s.loaded_from} "
+        Bundler.ui.debug "from #{s.loaded_from}"
       end
     end
 

diff --git a/spec/other/outdated_spec.rb b/spec/other/outdated_spec.rb
@@ -1,4 +1,5 @@
 require "spec_helper"
+require "pp"
 
 describe "bundle outdated" do
 
@@ -10,8 +11,7 @@
 
       install_gemfile <<-G
         source "file://#{gem_repo2}"
-        gem "activesupport"
-        gem "rack-obama"
+        gem "activesupport", "2.3.5"
         gem "foo", :git => "#{lib_path('foo')}"
       G
     end