Add isPublic field for query performance

Follow-up for ecamp#8004

Querying by isPrototype OR isShared is slow, because databases don't
like OR conditions too much. We work around this by adding a combined
isPublic field which is enforced to always contain isShared || isPrototype
and have the DB queries filter by that.

Author: carlobeltrame

api/fixtures/camps.yml

@@ -54,6 +54,7 @@ App\Entity\Camp:
     addressCity: <city()>
     owner: '@admin'
     creator: '@admin'
+    isPublic: true
     isPrototype: true
     isShared: false
     sharedBy: null
@@ -69,6 +70,7 @@ App\Entity\Camp:
     addressCity: <city()>
     owner: '@admin'
     creator: '@admin'
+    isPublic: true
     isPrototype: false
     isShared: true
     sharedBy: '@admin'

api/migrations/schema/Version20251004093025.php

@@ -0,0 +1,58 @@
+<?php
+
+declare(strict_types=1);
+
+namespace DoctrineMigrations;
+
+use Doctrine\DBAL\Schema\Schema;
+use Doctrine\Migrations\AbstractMigration;
+
+/**
+ * Auto-generated Migration: Please modify to your needs!
+ */
+final class Version20251004093025 extends AbstractMigration {
+    public function getDescription(): string {
+        return '';
+    }
+
+    public function up(Schema $schema): void {
+        // this up() migration is auto-generated, please modify it to your needs
+        $this->addSql('ALTER TABLE camp ADD isPublic BOOLEAN DEFAULT false NOT NULL');
+        $this->addSql('UPDATE camp SET isPublic = (isShared OR isPrototype)');
+        $this->addSql('ALTER TABLE camp ADD CONSTRAINT enforce_public_flag CHECK (isPublic = (isShared OR isPrototype))');
+        $this->addSql('CREATE INDEX IDX_C1944230FADC24C7 ON camp (isPublic)');
+        $this->addSql(
+            <<<'EOF'
+                    CREATE OR REPLACE VIEW public.view_user_camps
+                    AS
+                    SELECT CONCAT(u.id, c.id) id, u.id userid, c.id campid
+                    from camp c, "user" u
+                    where c.ispublic = TRUE
+                    union all
+                    select	cc.id, cc.userid, cc.campid
+                    from	camp_collaboration cc
+                    where 	cc.status = 'established'
+                EOF
+        );
+    }
+
+    public function down(Schema $schema): void {
+        // this down() migration is auto-generated, please modify it to your needs
+        $this->addSql(
+            <<<'EOF'
+                    CREATE OR REPLACE VIEW public.view_user_camps
+                    AS
+                    SELECT CONCAT(u.id, c.id) id, u.id userid, c.id campid
+                    from camp c, "user" u
+                    where c.isprototype = TRUE or c.isshared = TRUE
+                    union all
+                    select	cc.id, cc.userid, cc.campid
+                    from	camp_collaboration cc
+                    where 	cc.status = 'established'
+                EOF
+        );
+        $this->addSql('DROP INDEX IDX_C1944230FADC24C7');
+        $this->addSql('ALTER TABLE camp DROP CONSTRAINT enforce_public_flag');
+        $this->addSql('ALTER TABLE camp DROP isPublic');
+    }
+}

api/src/Entity/Camp.php

@@ -69,6 +69,7 @@
 #[ORM\Entity(repositoryClass: CampRepository::class)]
 #[ORM\Index(columns: ['isPrototype'])]
 #[ORM\Index(columns: ['isShared'])]
+#[ORM\Index(columns: ['isPublic'])]
 #[ORM\Index(columns: ['updateTime'])] // TODO unclear why this is necessary, but doctrine forgot about this index from BaseEntity...
 class Camp extends BaseEntity implements BelongsToCampInterface, CopyFromPrototypeInterface {
     public const ITEM_NORMALIZATION_CONTEXT = [
@@ -228,6 +229,14 @@ class Camp extends BaseEntity implements BelongsToCampInterface, CopyFromPrototy
     #[ORM\Column(type: 'boolean')]
     public bool $isPrototype = false;
 
+    /**
+     * Automatically set to the value (isShared || isPrototype). Used for more efficient
+     * database filtering operations, since OR queries are very expensive to compute.
+     * This is only used in the database, and therefore not available on the API.
+     */
+    #[ORM\Column(type: 'boolean', nullable: false, options: ['default' => false])]
+    public bool $isPublic = false;
+
     /**
      * An optional short title for the camp. Can be used in the UI where space is tight. If
      * not present, frontends may auto-shorten the title if the shortTitle is not set.

api/src/State/CampCreateProcessor.php

@@ -34,6 +34,7 @@ public function onBefore($data, Operation $operation, array $uriVariables = [],
         $user = $this->security->getUser();
         $data->creator = $user;
         $data->owner = $user;
+        $data->isPublic = $data->isShared || $data->isPrototype;
 
         // copy from prototype, if given
         if (null !== $data->campPrototype) {

api/src/State/CampUpdateProcessor.php

@@ -32,6 +32,8 @@ public function __construct(
     }
 
     public function onBeforeSharingStatusChange(Camp $data): Camp {
+        $data->isPublic = $data->isShared || $data->isPrototype;
+
         if ($data->isShared) {
             $data->sharedSince = new \DateTime('now', new \DateTimeZone('UTC'));