Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attachment support for Webex (wxteams) #1256

Open
cybermartini opened this issue Dec 15, 2024 · 2 comments
Open

Add attachment support for Webex (wxteams) #1256

cybermartini opened this issue Dec 15, 2024 · 2 comments

Comments

@cybermartini
Copy link

cybermartini commented Dec 15, 2024

💡 Include attachments/files in JSON sent to Webex

I would like to include a picture with the notification to Webex teams, not just text/markdown.

The Webex Message API supports the 'files' and 'attachment' keys, to include images. Apprise's NotifyWebexTeams currently only supports sending markdown or text, in the JSON payload so images cannot be sent through.

@caronc
Copy link
Owner

caronc commented Dec 16, 2024

Should be pretty straight forward to do. Webex has a cap of 10MB in files (either cumulative, or 1 can not exceed this size). How would you expect Apprise to handle 1 large 11MB file (as an example). Should it reject it?

For multiple files, should sequence be honored? Say:

  • file1 is 8MB
  • file2 is 5MB
  • file3 is 1MB

If sequence isn't an issue, file1 and file3 could be included in the same payload (reducing messages). Alternatively, file1 + file2 >10MB so it would break into a second message (total of 3 sent to honor sequence).

Thoughts?

Chris

@caronc
Copy link
Owner

caronc commented Dec 18, 2024

Turns out this is a bigger issue then i thought. The current Webex support is for Webex Incoming Webehook URL only which does not support Attachments i'm afraid.

I need to re-engineer the plugin entirely to support Webex Teams API. Your request is still possible, but it just got much more complicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants