Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move lesson example's style guide to handbook #203

Closed
rgaiacs opened this issue Apr 29, 2019 · 13 comments
Closed

Move lesson example's style guide to handbook #203

rgaiacs opened this issue Apr 29, 2019 · 13 comments
Assignees
Labels
transferred-issue Issues transferred from old handbook repo

Comments

@rgaiacs
Copy link

rgaiacs commented Apr 29, 2019

http://carpentries.github.io/lesson-example/06-style-guide/index.html need to be moved to here.

@maneesha
Copy link
Collaborator

Thanks @rgaiacs
As an end user, where in the Handbook would it make most sense for this to go for you?

@rgaiacs
Copy link
Author

rgaiacs commented Apr 29, 2019

As an end user, where in the Handbook would it make most sense for this to go for you?

https://docs.carpentries.org/topic_folders/communications/style-guide.html It should have a section about code.

@maneesha maneesha self-assigned this Apr 29, 2019
@brownsarahm
Copy link

the intro to the Handbook Style Guide says that it doesn't necessarily apply to lessons though, should that also change if we pull the current lesson style guide into the Handbook Style Guide?

@rgaiacs
Copy link
Author

rgaiacs commented Apr 30, 2019

the intro to the Handbook Style Guide says that it doesn't necessarily apply to lessons though

I read it as "this Style Guide doesn't apply to the lessons in Spanish" or "this Style Guide doesn't apply to the lesson that we are prototyping and is being lead by instructors only from country C". I think that for the the main lessons we should use the Style Guide.

@brownsarahm
Copy link

it says, in the second paragraph(emphasis mine):

We will adhere to a similar style on our website and in other material we make widely available such as blog posts, but not necessarily in lessons

I agree that for the main lessons we should use the Style Guide, but if we are going to, we should remove that phrase from the style guide.

@maneesha
Copy link
Collaborator

@zkamvar I think this falls under the work you do. Is this something we should keep open?

@maneesha
Copy link
Collaborator

maneesha commented Sep 8, 2021

Pinging @zkamvar

@maneesha
Copy link
Collaborator

maneesha commented Nov 4, 2021

Checking in @zkamvar

@bencomp
Copy link

bencomp commented Oct 18, 2022

I just mentioned in carpentries/lesson-example#258 that the link to the Style guide in the Handbook is broken.

As a maintainer/lesson contributor, I would like to have a single style guide for lesson contents. I feel that adding (or rather moving) the current style guide from the lesson example to the Handbook Style guide would make the latter even less easy to navigate. (The table of contents on the left only lists letters, so I have to search or browse the whole page to see if the guide could answer my question.)

The lesson example style guide helps with markup (and Markdown), whereas the Handbook's Style guide is focused on the text contents.
It could help to make this distinction more clearly and to add a reference to the lesson style guide, which of course will soon be the Workbench's guide.

@maneesha
Copy link
Collaborator

@zkamvar can we close this given the new lesson templates you are releasing?

@bencomp
Copy link

bencomp commented Jun 21, 2023

I rediscovered the Lesson Development handbook today and wonder if that should be the place for a lesson style guide.

@maneesha
Copy link
Collaborator

@tobyhodges Do you want to keep this issue active in the new handbook? If it is no longer relevant, we can close this issue.

@maneesha maneesha assigned tobyhodges and unassigned maneesha Oct 24, 2024
@maneesha maneesha transferred this issue from carpentries/docs.carpentries.org-archive Nov 7, 2024
@maneesha maneesha added the transferred-issue Issues transferred from old handbook repo label Nov 7, 2024
@tobyhodges
Copy link
Member

I think we can close this issue. I drafted a style guide for the Workbench infrastructure, and in my opinion it makes more sense as a part of that documentation site, as opposed to belonging in the central handbook. My main argument for this is that sandpaper/the Workbench is being quite widely used outside The Carpentries, and the guidance we are providing in the style guide is relevant to all of those porjects, as opposed to only The Carpentries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
transferred-issue Issues transferred from old handbook repo
Projects
None yet
Development

No branches or pull requests

5 participants