Warning messages: In page_globals$meta : partial match of 'meta' to 'metadata'

[Bisaloo]

I enabled warnings on partial matching by default on my computer and got these while running sandpaper::serve():

Warning messages: In page_globals$meta : partial match of 'meta' to 'metadata'

Looking at the code, it seems indeed that there are a couple of occurrence of this:

https://github.com/search?q=repo%3Acarpentries%2Fsandpaper+%2Fpage_globals%5C%24meta%5Cb%2F&type=code

And a look at setup_page_globals() seems to confirm that the object it creates indeed contains a metadata element but no meta element.

sandpaper/R/utils-varnish.R

Lines 110 to 119 in 043bf7d

	setup_page_globals <- function() {
	instructor_local <- instructor_globals$copy()
	learner_local <- learner_globals$copy()
	metadata_local <- this_metadata$copy()
	return(list(
	instructor = instructor_local,
	learner = learner_local,
	metadata = metadata_local
	))
	}

I'm opening this issue first to confirm I understood everything correctly and this is indeed what's happening. If so, I'm happy to submit a PR to not rely on partial matching and avoid potential name collisions.

[zkamvar]

This is absolutely correct! The set_page_globals() function will make copies of the global cache so that things like the pre-computed metadata and sidebar can be modified to suit a particular page: https://github.com/search?q=repo%3Acarpentries%2Fsandpaper%20setup_page_globals&type=code

My documentation for the global lesson elements of sandpaper is... not great I admit.

I would be really grateful for a PR!