-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conditional versions checking everytime uploader called? #2132
Comments
same problem here |
Have the same problem currently using version 2.2.2 |
Bumping, this needs input from the authors. |
The change itself came from #1351, but makes some sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
after update of Carrierwave from 0.6.2 to 1.0.0, our app started to be painfully slow.
We use conditional versions in an uploader i.e.
Object#logo
. By methodis_big_enough?
, it checks source image resolution (using mini_magick gem) before versions:medium
and:large
are created - to prevent increasing of image resolution i.e. from 200x200px to 400x400px.There are other versions without conditionals:
:small
and:semi_small
In Carrierwave v. 0.6.2, if I call
object.logo.small.url
, conditional methodis_big_enough?
is not called.In Carrierwave v. 1.0.0, conditional method
is_big_enough?
seems to be called everytime.In a big page with 100+ calls to various instances of the uploader, loading of page starts to be painfully slow, because
is_big_enough?
uses mini_magick which touches HDD/SDD.Is this desired behavior because of some reason or it happens by mistake?
Thank you
The text was updated successfully, but these errors were encountered: