Pop-up is too low on Android

[rpander93]

Hi there,

We found that the pop-up is too low on Android if not using the translucent statusbar. In our case, we switched from managing the statusbar with the component to letting Android manage it. We then saw that the pop-up was rendered with a top margin of approx. 1x the height of the statusbar. This is caused by:

react-native-push-notification-popup/src/views/DefaultPopup.js

Line 14 in 614575e

StatusBar.currentHeight + 10); // Just to add a bit more padding

Setting this to 0 manually fixes the issue. Unfortunately it seems that this is not configurable, so we had do copy the whole file just to make this adjustment. Is this something that could be fixed?

[carsonwah]

@rpander93 Sorry for the late reply. Oh I overlooked this.
This is because if StatusBar is not translucent, the whole app will be rendered starting at the bottom of the StatusBar.

So the correct height should be:

• iOS with notch: 44
• iOS without notch: 20
• Android with translucent StatusBar: StatusBar.currentHeight + 10
• Android with non-translucent StatusBar: 10

Seems there is no way to determine in code whether StatusBar is translucent or not. I will opt for externalizing it as props. Will find a time to implement this. Thanks for reporting and sorry for the inconvenience caused.

[rpander93]

No worries! That's indeed what's going on. Thanks for looking into it.

[NxsHbb]

Any update!

[carsonwah]

Fixed in v1.7.0.
https://www.npmjs.com/package/react-native-push-notification-popup/v/1.7.0