Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Best or more strict configuration of rxjs-tslint #58

Open
pablorsk opened this issue Aug 23, 2018 · 4 comments
Open

Best or more strict configuration of rxjs-tslint #58

pablorsk opened this issue Aug 23, 2018 · 4 comments
Labels

Comments

@pablorsk
Copy link

What is the best configuration or more strict configuration of rxjs-tslint-rules?

        "rxjs-add": true,
        "rxjs-ban-observables": true,
        "rxjs-ban-operators": true,
        "rxjs-deep-operators": true,
        "rxjs-no-create": true,
        "rxjs-no-unsafe-catch": true,
        "rxjs-no-unsafe-first": true,
        "rxjs-no-unsafe-switchmap": true,
        "rxjs-no-unsafe-takeuntil": true,
        "rxjs-no-unused-add": true,
        "rxjs-no-wholesale": true,
        "rxjs-throw-error": true,

On tslint, all rules=true is the more strict method. This rules too?

@cartant
Copy link
Owner

cartant commented Aug 23, 2018

No. You cannot just enable all of the rules. Some rules are contradictory. For example, enabling both rxjs-finnish and rxjs-no-finnish would make no sense.

You will need to read the rule descriptions and will need to decide which rules you think are appropriate.

Also, quite a few of the rules are v5-only. This information is in the rules' metadata and said rules will be deprecated/disabled if used with an RxJS v6 project. At some stage, I'll add some information to the README's table so it's more obvious.

I've spoken with Ben Lesh about compiling a recommended list of rules and adding them to the rxjs-tslint package, but this has not yet been done.

@cartant
Copy link
Owner

cartant commented Feb 24, 2019

@pablorsk If you are interested, I've done some rearranging of my projects to consolidate the RxJS linting rules that I use into one shared location: @cartant/tslint-config-rxjs.

With it, the tslint.json files in my projects look like this.

I'm undecided on rxjs-no-unsafe-scope as an error. I might switch to be just be a warning.

@the-ult
Copy link

the-ult commented Oct 31, 2019

Is it possible to create a shareable rxjs-tslint-rules:recommended in this project from which we can extend?
And describe it in the readme.md

Like:

@see cartant/eslint-plugin-rxjs#40

@cartant
Copy link
Owner

cartant commented Oct 31, 2019

See this comment in the repo that contains the ESLint versions of these rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants