New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests to make sure a voucher is executed to complete a withdrawal #7

Open

5 tasks

marcelstanley opened this issue Jun 1, 2023 · 1 comment

Contributor

marcelstanley commented Jun 1, 2023 •

edited

Loading

📚 Context

Test Withdraw request from WITHDRAW_ADDRESS results in a voucher does not test the full procedure, which could include the execution of the voucher itself.

✔️ Solution

Add the following steps to the test:

Finish the epoch
Execute the voucher
Check Bob's balance to make sure the funds were transferred correctly

📈 Subtasks

Advance time
Execute the voucher
Check Bob's balance

🎯 Definition of Done

Test passes and Bob's balance matches what is expected
All tests pass

marcelstanley changed the title ~~Improve tests~~ Improve tests to make sure a voucher is executed to complete a withdrawal

Abtrade2023 commented Oct 30, 2023

Tks you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment