Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear up configs and legacy Node/EvmReader code #13

Open
miltonjonat opened this issue Feb 3, 2025 · 1 comment · May be fixed by #20
Open

Clear up configs and legacy Node/EvmReader code #13

miltonjonat opened this issue Feb 3, 2025 · 1 comment · May be fixed by #20
Assignees
@ZzzzHui

Comments

@miltonjonat
Copy link
Collaborator

The EspressoReader currently expects several configurations (env vars) that make no sense for its operation, such as:

  • CARTESI_AUTH_MNEMONIC (it does not submit any tx to the blockchain)
  • CARTESI_TEST_POSTGRES_ENDPOINT (unused)
  • CARTESI_TEST_MACHINE_IMAGES_PATH (unused)
  • PATH (is this used?)
  • CGO_CFLAGS and CGO_LDFLAGS (unused)

Likewise, there is a lot of code that relates to running the full Node and EvmReader (e.g., internal/repository/claimer.go).
We should clean-up all code that has nothing to do with the EspressoReader, and internalize/copy only the necessary code from the current EvmReader (ideally reuse EvmReader itself, but, if that is not possible, copy only the relevant parts and not the whole thing)
@miltonjonat miltonjonat mentioned this issue Feb 4, 2025
Open
@ZzzzHui
Copy link
Collaborator

ZzzzHui commented Feb 6, 2025

ideally reuse EvmReader itself, but, if that is not possible, copy only the relevant parts and not the whole thing

the EVM reader in espresso already only contains what's needed by the espresso. Not the whole thing actually. I've looked into this, it is a bit difficult to not re-use the evm reader

@ZzzzHui ZzzzHui linked a pull request Feb 9, 2025 that will close this issue
cleanup #20
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZzzzHui ZzzzHui

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cleanup cartesi/rollups-espresso-reader
2 participants
@miltonjonat @ZzzzHui