Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server manager should look for remote-cartesi-machine in PATH #7

Closed
edubart opened this issue Aug 16, 2023 · 0 comments · Fixed by #16
Closed

Server manager should look for remote-cartesi-machine in PATH #7

edubart opened this issue Aug 16, 2023 · 0 comments · Fixed by #16
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@edubart
Copy link
Contributor

edubart commented Aug 16, 2023

Context

Currently the server manager assumes /usr/bin/remote-cartesi-machine is available, but the cartesi machine could have been installed somewhere else, like /usr/local.

Possible solutions

The server manager should not make hard-coded assumptions where the cartesi machine is installed, it should detect this by using environment variables such as PATH , CARTESI_IMAGES_PATH, or even some new environment variable like CARTESI_SDK_PATH in case necessary.

@edubart edubart added the enhancement New feature or request label Aug 16, 2023
@vfusco vfusco self-assigned this Aug 17, 2023
@edubart edubart changed the title Make server manager find remote cartesi machine from PATH Server manager should look for remote-cartesi-machine in PATH Aug 22, 2023
@vfusco vfusco mentioned this issue Nov 21, 2023
@vfusco vfusco linked a pull request Nov 21, 2023 that will close this issue
@vfusco vfusco added this to the v0.9.0 milestone Dec 20, 2023
@vfusco vfusco closed this as completed in #16 Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants