-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip checking resources when --wait=false
is specified
#577
Comments
--wait=false
is specified--wait=false
is specified
Yeah, it seems like setting the wait flag to false would currently lead to an error while deleting recorded apps. So definitely it's a bug.
It does makes sense to allow that behaviour, I am just trying to think of any side effects it could have. One obvious thing that could happen is that one or more resources are not deleted but the app itself (metadata configmap) is deleted.
That would be great, we will definitely review it on priority once we finalize the approach :) |
Hey @firgavin good to see your here. Looking forward to your PR for this issue. |
This would be a "known risk" I guess? We might also lose out on some "retryable cases", where |
i think additional flag would be reasonable to disable this check. may be under dangerous? |
This approach makes sense to me |
Hi @cppforlife, @100mik, @praveenrewar - Thanks for your insights! Here's my proposal: We can add a flag
Before I work on it, I'd like to discuss the interaction between the two flags. When |
I think that we should keep the working of these 2 flags independent of each other because a user should be able to use
Maybe we can add a hint in the error message? |
What steps did you take:
I currently use Kapp as a CI tool to manage lots of YAML files. I used
--wait=false
when I deleted the app because sometimes deleting custom resources will take a long time.What happened:
kapp exits with non-zero code which makes CI fail.
What did you expect:
Kapp could skip checking resources when
--wait=false
is specified.Anything else you would like to add:
I did some research and I found that kapp checks the existence of related resources after applying changes. But resources will be deleted eventually. See https://github.com/vmware-tanzu/carvel-kapp/blob/v0.52.0/pkg/kapp/cmd/app/delete.go#L159.
It would be great if kapp could default to skipping checking resources when
--wait=false
is specified or add a flag to control this logic. And if that makes sense, I'd like to help implement this ;)Environment:
kapp --version
): v0.52.0/etc/os-release
): Ubuntu 20.04.4 LTSkubectl version
): v1.23.6+k3s1Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you want to help working on this issue.
The text was updated successfully, but these errors were encountered: