Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possibility to add custom headers for HTTP downloads #87

Open
dburgermeister opened this issue Jul 14, 2021 · 2 comments · May be fixed by #371
Open

Possibility to add custom headers for HTTP downloads #87

dburgermeister opened this issue Jul 14, 2021 · 2 comments · May be fixed by #371
Labels
carvel-accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request

Comments

@dburgermeister
Copy link

Describe the problem/challenge you have
Some websites request to add specific HTTP headers, like for example API Token to access the files.
Currently it seems not possible to add those headers in the yaml file.
Example: wget -O --header="Authorization: Token *************"

Describe the solution you'd like
Add a new field in the vendir.yaml configuration file for each header.

Anything else you would like to add:
Thank you :)

Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.
@dburgermeister dburgermeister added carvel-triage This issue has not yet been reviewed for validity enhancement This issue is a feature request labels Jul 14, 2021
@cppforlife
Copy link
Contributor

@dburgermeister yeah that makes sense. we probably would want to pull them in from a secret since sounds like some headers might include sensitive information. would you be interested in contributing this?

@cppforlife cppforlife added carvel-accepted This issue should be considered for future work and that the triage process has been completed and removed carvel-triage This issue has not yet been reviewed for validity labels Jul 21, 2021
@voor
Copy link

voor commented Nov 2, 2023

This use case came up again recently with someone adopting HTTP fetch in the App CR.

They specifically used the GitHub API, and were unable to add authorization to the URL: https://docs.github.com/en/rest/overview/authenticating-to-the-rest-api?apiVersion=2022-11-28

@renuy renuy added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jan 2, 2024
@christopherfriedrich christopherfriedrich linked a pull request Mar 29, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
carvel-accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request
Projects
Carvel
Status: Prioritized Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce possibility for custom HTTP Headers in HTTP source christopherfriedrich/vendir
4 participants
@cppforlife @renuy @voor @dburgermeister