Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add support for legacy array definition method #313

Merged
merged 4 commits into from
Aug 13, 2021
Merged

fix: add support for legacy array definition method #313

merged 4 commits into from
Aug 13, 2021

Conversation

Zxilly
Copy link
Contributor

@Zxilly Zxilly commented Aug 13, 2021 •
edited
Loading

resolve: #308

about: casbin/casbin#863

Signed-off-by: Zxilly zhouxinyu1001@gmail.com

@Zxilly Zxilly requested review from hsluoyz and nodece August 13, 2021 05:49
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1126598072

  • 0 of 17 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 77.25%
Totals Coverage Status
Change from base Build 1126087929: 0.2%
Covered Lines: 1313
Relevant Lines: 1631
💛 - Coveralls

@coveralls
Copy link

coveralls commented Aug 13, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1126598072

  • 17 of 17 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 77.25%
Totals Coverage Status
Change from base Build 1126087929: 0.2%
Covered Lines: 1313
Relevant Lines: 1631
💛 - Coveralls

@hsluoyz
Copy link
Member

hsluoyz commented Aug 13, 2021

@lantu-group plz review

@nodece
Copy link
Member

nodece commented Aug 13, 2021

@Zxilly Please fix CI.

nodece
nodece approved these changes Aug 13, 2021
View reviewed changes
Copy link
Member

@nodece nodece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Zxilly added 4 commits August 13, 2021 21:07
@Zxilly
fix: add support for legacy array definition method
b66d6f8 
Signed-off-by: Zxilly <zhouxinyu1001@gmail.com>
@Zxilly
fix: add exception catch
37fb271 
Signed-off-by: Zxilly <zhouxinyu1001@gmail.com>
@Zxilly
fix: resolve conflict
a2d4eb3 
Signed-off-by: Zxilly <zhouxinyu1001@gmail.com>
@Zxilly
fix: reimplement preprocessor
72d73db 
To support old style usage like `r.sub.Doc in (r.obj.Docs)`

Signed-off-by: Zxilly <zhouxinyu1001@gmail.com>
@Zxilly Zxilly requested a review from nodece August 13, 2021 13:57
@Zxilly
Copy link
Contributor Author

Zxilly commented Aug 13, 2021

@nodece I turned to a new implementation, plz review

@nodece nodece merged commit 635eece into casbin:master Aug 13, 2021
github-actions bot pushed a commit that referenced this pull request Aug 13, 2021
@semantic-release-bot
chore(release): 5.11.3 [skip ci]
c2a5aba 
## [5.11.3](v5.11.2...v5.11.3) (2021-08-13)

### Bug Fixes

* add support for legacy array definition method ([#313](#313)) ([635eece](635eece))
@github-actions
Copy link

🎉 This PR is included in version 5.11.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Zxilly Zxilly mentioned this pull request Aug 29, 2021
Merged
@Zxilly Zxilly deleted the preprocess branch April 15, 2022 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsluoyz hsluoyz Awaiting requested review from hsluoyz

@nodece nodece Awaiting requested review from nodece

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

&& Error
4 participants
@Zxilly @coveralls @hsluoyz @nodece