Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Filtered Adapters #65

Closed
wakemaster39 opened this issue Aug 11, 2020 · 1 comment · Fixed by #66
Closed

Support for Filtered Adapters #65

wakemaster39 opened this issue Aug 11, 2020 · 1 comment · Fixed by #66
Assignees
@hsluoyz
Labels
enhancement New feature or request

Comments

@wakemaster39
Copy link

wakemaster39 commented Aug 11, 2020 •
edited
Loading

Running PyCasbin in a production environment with a decent size of rules (~30k) pycasbin starts to fall apart. Looping over the policy to find out if each rule matches only to find out that r.obj != s.obj is pretty painful.

Without completely obliterating the internals of casbin to hard code certain checks exist and using things like sets or dictionaries to get the performance up, filtered queries are very much required.
@wakemaster39 wakemaster39 mentioned this issue Aug 11, 2020
Merged
@hsluoyz hsluoyz self-assigned this Sep 18, 2020
@hsluoyz hsluoyz added the enhancement New feature or request label Sep 18, 2020
@hsluoyz
Copy link
Member

hsluoyz commented Sep 18, 2020

@wakemaster39 merged.

@techoner can you make a new release?

@wakemaster39 wakemaster39 mentioned this issue Sep 18, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsluoyz hsluoyz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added support for filtered policies wakemaster39/pycasbin
2 participants
@wakemaster39 @hsluoyz