Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThermoPower.Water.Flow1Dfem2ph has duplicate but non-identical declarations #18

Open
maltelenz opened this issue Nov 5, 2020 · 0 comments

Comments

@maltelenz
Copy link
Contributor

There are duplicated declarations of g in ThermoPower.Water.Flow1Dfem2ph.

Output from System Modeler:

Error: ThermoPower.Water.Flow1Dfem2ph [1:5-1:5] Invalid class definition. Element g is duplicated, but its definitions are not identical.
  constant public Real g = .Modelica.Constants.g_n
  constant public .Modelica.SIunits.Acceleration g(quantity = "Acceleration", unit_ = "m/s2") = .Modelica.Constants.g_n

The two definitions seem to come from:

constant Real g=Modelica.Constants.g_n;

The second one from the base class:

constant SI.Acceleration g=Modelica.Constants.g_n;

I see ThermoPower.Water.Flow1Dfem2ph is marked obsolete using an icon, but it is still used in ThermoPower.Test.DistributedParameterComponents.TestFlow1Dfem2ph. Maybe the usage there should just be replaced with the similarly named ThermoPower.Water.Flow1DFEM2ph (note the uppercase FEM)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant