-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sha256sum files incompatable with shasum -c #2398
Comments
This was actually fixed in #2358, but I haven't done another release since. Just released 1.36.0, which has correct shasum files with relative paths: https://github.com/casey/just/releases/tag/1.36.0 |
Just a heads up for anyone using the shasum files: In #2417 I changed the release workflow to generate a single |
As implemented by Generate .sha256sum files for release artifacts the resulting
.sha256sum
files do not meet the requirements of macOS's shasum -c / --check nor the corresponding option in Linux'sshasum
andsha256sum
commands. Currently the sha256sum files contain absolute paths like/{Users,home}/runner/work/just/just/dist/just-$VERSION-$TARGET.tar.gz
which will not exist for users wanting to easily verify downloads' hash values.Since the
bin/package
script does acd $DIST
before generating the hash value, a suggested fix is rather thanshasum -a 256 $ARCHIVE > $ARCHIVE.sha256sum
to use shell parameter expansion to remove $DIST from the beginning of the full $ARCHIVE path:
shasum -a 256 ${ARCHIVE#$DIST/} > $ARCHIVE.sha256sum
I've minimally tested that and it seems to do the right thing so that
shasum --check *.sha256sum
andsha256sum --check *.sha256sum
verify the corresponding tar.gz's hash when both are downloaded into the same directory, as is likely typical of most users. To eliminate any user confusion on Windows I suggest doing the same for that target's sha256sum file as well, assumingcertutil
won't know what to do about the*/d/a/just/just/dist/
path in the corresponding sha256sum file.The text was updated successfully, but these errors were encountered: