Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support other "external" resource types #39

Open
dellisd opened this issue Jan 24, 2023 · 0 comments
Open

Support other "external" resource types #39

dellisd opened this issue Jan 24, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@dellisd
Copy link
Collaborator

dellisd commented Jan 24, 2023

Right now the plugin can handle external style declarations, i.e. if a style resource is referenced in the base module's merged manifest that isn't actually included in the base module.

This isn't currently possible with other types of resources (e.g. strings or xml resources) which forces us to include some dependencies in the base module that we really shouldn't need to and inflates our base APK size.


The plugin is already capable of identifying resources of any type that are referenced in the merged manifest and not included in the base module, so perhaps the plugin could locate these resources from their original source and effectively copy their values into the base module (as generated resources) to satisfy the resource linking process without having to actually include a dependency on those dependencies.

@dellisd dellisd added the enhancement New feature or request label Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant