Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InstantAnimationsRule doesn't work with Compose #901

Open
BraisGabin opened this issue May 29, 2023 · 1 comment
Open

InstantAnimationsRule doesn't work with Compose #901

BraisGabin opened this issue May 29, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@BraisGabin
Copy link

InstantAnimationsRule doesn't work with compose.

I have some components that have animations and it would be great to be able to take a screenshot of the last frame.

This use case could be fullfilled with #627 or #752. Anyway it would be great than instead of hardcode an offset you could just say "take a screenshot of the last frame".

@BraisGabin BraisGabin added the enhancement New feature or request label May 29, 2023
@geoff-powell geoff-powell self-assigned this Sep 26, 2024
@geoff-powell geoff-powell added this to the 1.3.5 milestone Sep 26, 2024
@geoff-powell
Copy link
Collaborator

Wanted to give an update here. For now we will not be supporting Compose animations for this test rule. It was implemented in a time where gif support was not ready and now we have APNG support for animations. Our suggestion for capturing this is the following (per @jrodbx 😉):

If frames = 1, snapshot static image
If frames = 2, grrr, but ok, we allow via pending recompositions, cuz androidx Composable kinda misbehave require another pass?
if frames > 2, either use gif support OR you have a bug, fix yo' UI widget.

We will think on this use case in our upcoming 2.0 rewrite.

@geoff-powell geoff-powell modified the milestones: 1.3.5, 1.4, 1.4+ Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants