You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When melting the wallet can over pay the melt quote and have the change returned once the payment is complete. However in an error cash this can lead to ecash being stuck in a pending state. The wallet should select proofs and swap before a melt if it does not have proofs equal to the melt quote. Swapping before increases fees and requires an extra operation but is preferable to risking stuck ecash.
@davidcaseria just tagging you for tracking as we've talked about this before, but don't think we've fixed it.
The text was updated successfully, but these errors were encountered:
@crodas and I spoke about this and my suggestion would be in the melt function we add in a check once we select input_proofs. In the case that it is a mint that does not support nut08 the value should be exactly that of the quote amount + fee_reserve. In the case that it is a mint that does support nut08 the value should be <= quote_amount + fee_reserve + some tolerance. For the tolerance we could just pick some value we're willing to risk, or be smarter about it and it could be something like the tolerance = the extra fee we would pay to swap.
Then we leave the melt_proofs function as it is since the extra logic to handle the swap is in the melt and if some wants to do their own coin selection and risk more stuck in the pending that's on them and we should allow it.
@crodas believe you're gonna take this one if not let me know and I'll reassign.
When melting the wallet can over pay the melt quote and have the change returned once the payment is complete. However in an error cash this can lead to ecash being stuck in a pending state. The wallet should select proofs and swap before a melt if it does not have proofs equal to the melt quote. Swapping before increases fees and requires an extra operation but is preferable to risking stuck ecash.
@davidcaseria just tagging you for tracking as we've talked about this before, but don't think we've fixed it.
The text was updated successfully, but these errors were encountered: