Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Memory database #607

Open
thesimplekid opened this issue Feb 18, 2025 · 2 comments
Open

Remove Memory database #607

thesimplekid opened this issue Feb 18, 2025 · 2 comments
Assignees

Comments

@thesimplekid
Copy link
Collaborator

We've discussed removing the memory database from the mint database. In cases where an in memory database is desired an in memory sql db could be used and it removed the need for us to maintain another db within cdk. I think this is fairly obvious for the mint should be also do it for the wallet?

cc @crodas

@crodas
Copy link
Contributor

crodas commented Feb 18, 2025

I have started working on it and will submit a PR shortly. In my PR, SQLite with :memory: is being used, with migration every time the Memory Database is being created.

The main benefit would be fewer things to maintain, specially when transactions changes are added to the database, it will be implemented already by the SQLite driver.

Does this sound like a plan?

@thesimplekid
Copy link
Collaborator Author

Does this sound like a plan?

Yes I'm happy we do this for both mint and wallet unless, anyone thinks we should keep it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants