Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onEventPushed in EventStore constructor #182

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joyanedel
Copy link

@joyanedel joyanedel commented Jan 20, 2024

Description 🦫

EventStore documentation indicates that the constructor is able to receive onEventPushed as an argument in the constructor but the base code doesn't support it

In the company I work, we are exploring castore in an eventsourcing based project and this fix can lead into cleaner code.

Fixes #178

Type of change 📝

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? 🧑‍🔬

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • core:package
  • core:test
  • message-bus-adapter-event-bridge:package
  • message-bus-adapter-event-bridge:test
  • event-storage-adapter-in-memory:test
  • command-json-schema:package
  • event-type-json-schema:package
  • event-storage-adapter-redux:test
  • event-storage-adapter-http:test
  • message-queue-adapter-sqs:test
  • event-storage-adapter-redux:package
  • event-type-json-schema:test
  • command-json-schema:test
  • event-storage-adapter-in-memory:package
  • event-type-zod:test
  • command-zod:test
  • demo-blueprint:package
  • message-bus-adapter-event-bridge-s3:test
  • demo-blueprint:test
  • lib-react-visualizer:package
  • lib-react-visualizer:test
  • message-queue-adapter-in-memory:test
  • event-storage-adapter-dynamodb:test
  • message-bus-adapter-in-memory:test
  • event-storage-adapter-dynamodb:package
  • lib-test-tools:test
  • lib-test-tools:package
  • message-queue-adapter-in-memory:package
  • demo-visualization:test
  • demo-implementation:test
  • docs:test
  • lib-dam:test

Test Configuration: 🔧

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist: ✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add onEventPushed in EventStore constructor
1 participant