-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unfair to skip questions in test dataset #56
Comments
@xhuang31 Thank you so much for your comments! I rechecked the code and found that we indeed skipped some questions for whole dataset, not considering their sources. I recalculated and found that we ignore 54(0.2%) questions in test data. We will change our denominator when calculating the final results. |
Do you know any methods that could prevent this problem (reserve these dropped questions)? Does it requires a larger KB? I am a beginner of this area and have few related knowledge. Looking forward to your reply, thanks! |
@fwzlaughing Hi just have a quick fix here 73b5a42. |
Why some entities' names can't be found in FB5M.name.txt? Is there a complete dataset that contains all the entities' names of FB2M? |
@fwzlaughing FB5M is a subset of freebase. If you are interested in the full freebase, you could download the dump from https://developers.google.com/freebase/ |
In augment_process_dataset.py, some questions in the test dataset are skipped. It is unfair to use such results to compare to the state-of-the-art. Nothing should be changed in the test data.
The text was updated successfully, but these errors were encountered: