-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Lucene8 #679
Comments
+1 for ripping the band-aid off, seems like a good time to do it.
|
+1. Using ES 7+ (based on Lucene 8) right now would be pretty cool. |
+1. As @lintool mentioned, now seems a good time because there is no deadline in the near future. |
+1. I agree it's a good time to introduce a considerable change so that we can work on any issues until the next deadline. |
Update: I now have all our existing regressions passing on Lucene8, in a branch called
My proposal is to abandon the JDIQ regressions, because (1) the DRF model that we tested is obsolete Two more things I want to do: regressions for MS MARCO passage (#690) and doc (#691) - the reason is that I want to compare Lucene7 and Lucene8. Otherwise, I think we're good to go for merge. |
🎉 Lucene 8 has dropped! |
Next decision we need to make... upgrade to Lucene8? It's a matter of when.
Lucene8 promises to be faster: https://github.com/castorini/anserini/blob/master/docs/lucene7-vs-lucene8.md
However, Lucene8 yields a whole slew of changes to regression numbers... and will likely break a bunch of things.
My recommendation is to rip the bandaid off, accept that things are going to be broken for a bit, and then gradually fix. EMNLP and CIKM deadlines just passed; WSDM isn't for a while; ACL is far off in the distance.
The direct effects I can foresee are:
Anything else I missed? Downside of a large shared code-base used by the entire group... lots of effects...
cc @Peilin-Yang in case he has an opinion?
Thoughts, everyone? 👍 or 👎 or 🤷♂ or 🤷♀ ?
The text was updated successfully, but these errors were encountered: